fix(avr): download registry lib_deps before compilation - #1291
Conversation
|
Warning Review limit reached
Next review available in: 14 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Registry and remote lib_deps entries (e.g., fastled/FastLED@^3.10.3) were classified by 'fbuild sync' but never downloaded by the AVR build orchestrator, so the compile step couldn't find their headers. Add a shared ensure_lib_deps() helper to the build pipeline library module and call it from the AVR orchestrator before the compiler is created, so downloaded library include directories are available during compilation and their archives are linked into the firmware. The ESP32 orchestrator already called ensure_libraries() directly; this brings the AVR path up to parity. Other non-ESP32 orchestrators using run_sequential_build_with_libs() (Teensy, STM32, RP2040, SAM, CH32V, ESP8266, NRF52, Renesas, Silabs, Apollo3, NXP LPC) can adopt the same ensure_lib_deps() helper in follow-up PRs. Fixes #1276. Co-Authored-By: Claude <noreply@anthropic.com>
a44f546 to
770d5a8
Compare
1 participant
Problem
Registry and remote
lib_depsentries (e.g.,fastled/FastLED@^3.10.3) were classified byfbuild syncbut never downloaded by the AVR build orchestrator. The compile step would fail with:Fixes #1276.
Root Cause
The ESP32 orchestrator already called
ensure_libraries()to download and compilelib_depsbefore compilation. The AVR orchestrator (and all other non-ESP32 orchestrators usingrun_sequential_build_with_libs()) did not.Changes
crates/fbuild-build-engine/src/pipeline/library.rs— Newensure_lib_deps()helper that wrapsensure_libraries()fromfbuild-packages. Callable by any orchestrator before the compiler is created.crates/fbuild-build-mcu/src/avr/orchestrator.rs— Callsensure_lib_deps()after building the initial include-dir set but before creating the AVR compiler. Downloaded library include dirs are added to the compiler, and library archives are passed as extra link inputs.Verification
soldr cargo check --workspace— cleansoldr cargo clippy -p fbuild-build-engine -p fbuild-build-mcu -- -D warnings— cleansoldr cargo test -p fbuild-build-mcu -- avr— 27/27 passsoldr cargo test -p fbuild-build-engine -- pipeline— 20/20 passFollow-up
Other non-ESP32 orchestrators using
run_sequential_build_with_libs()(Teensy, STM32, RP2040, SAM, CH32V, ESP8266, NRF52, Renesas, Silabs, Apollo3, NXP LPC) can adopt the sameensure_lib_deps()helper in follow-up PRs.🤖 Generated with Claude Code